Core tests: safeguard against duplicate test markers #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/773-safeguard-against-duplicate-test-markers
branch
2 times, most recently
from
8169944 to
76f67ce
Compare
fredden
approved these changes
Jan 23, 2025
This commit adds a new test to both the `AbstractMethodUnitTest` and the `AbstractTokenizerTestCase` classes to automatically verify that the case file in use by the child test class only contains unique test markers. The actual logic for the test is in a custom, `static`, assertion `assertTestMarkersAreUnique()` to allow for calling the assertion directly if an additional test case file is tokenized for the test; and to prevent duplicating the logic in both test case classes. Includes fixing a few test markers which this new test identified as duplicates straight off. Fixes 773
jrfnl
force-pushed
the
feature/773-safeguard-against-duplicate-test-markers
branch
from
76f67ce to
0e9c8c5
Compare
jrfnl
deleted the
feature/773-safeguard-against-duplicate-test-markers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a test method to both the
AbstractMethodUnitTestand theAbstractTokenizerTestCaseclasses to automatically verify that the case file in use by a child test class only contains unique test markers.The actual logic for the test is in a custom,
static, assertionassertTestMarkersAreUnique()to allow for calling the assertion directly if an additional test case file is tokenized for the test; and to prevent duplicating the logic in both test case classes.Includes fixing a few test markers which this new test identified as duplicates straight off.
Suggested changelog entry
Changed: the
AbstractMethodUnitTestand theAbstractTokenizerTestCasewill now flag duplicate test case markers in a test case file.Related issues/external references
Fixes #773